Skip failed claims on Reality #649
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| @@ -202,6 +202,8 @@ def claim_all_bonds_on_reality( | |||
| api_keys, | |||
| questions, | |||
| auto_withdraw=True, | |||
| # Skip failed claims, because we don't want to block the whole process because of some failed claim. | |||
| skip_failed=True, | |||
There was a problem hiding this comment.
I don't know what happened, but this question was failing for a week to claim bonds on it.
However, as I was debugging it, on 5th try or so it suddenly passed (without any fix from my side).
So let's just skip any exceptions during claiming, as that shouldn't stop OFVChallenger from challenging/claming the next ones.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
prediction_market_agent/agents/replicate_to_omen_agent/omen_resolve_replicated.py (1)
205-206: LGTM! Consider enhancing the comment.The change to skip failed claims is a good defensive programming practice, making the system more resilient to transient failures. This is well-supported by the real-world example where claims occasionally fail but succeed on retry.
Consider enhancing the comment to be more specific about the types of failures that can occur:
- # Skip failed claims, because we don't want to block the whole process because of some failed claim. + # Skip failed claims to prevent transient failures (e.g., network issues, temporary contract state) + # from blocking the entire claiming process. Claims that fail can be retried in the next run.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
poetry.lockis excluded by!**/*.lock,!**/*.lockpyproject.tomlis excluded by!**/*.toml
📒 Files selected for processing (1)
prediction_market_agent/agents/replicate_to_omen_agent/omen_resolve_replicated.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: test-build-image
- GitHub Check: pytest-docker
- GitHub Check: pytest
- GitHub Check: mypy
No description provided.