Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errored function in reasoning #650

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

kongzii
Copy link
Contributor

@kongzii kongzii commented Jan 20, 2025

Related to #647, the fact that the errored function call isn't in the history is a feature of Microchain, not a bug.

We could refactor it a bit, but atm I'm not convinced that it has to change, so I did a "2025 programmers move" -- just ask the LLM to do it for us! 😄 For our needs it seems to work fine.

Screenshot by Dropbox Capture

Copy link
Contributor

coderabbitai bot commented Jan 20, 2025

Walkthrough

The changes involve updating the system prompt for a microchain agent by adding a new instruction for error handling. Specifically, the modification enhances error reporting by requiring the agent to include detailed information about any function that fails during execution. This update aims to improve debugging and traceability by mandating that the agent explicitly mention the exact function and its arguments when an error occurs.

Changes

File Change Summary
prediction_market_agent/agents/microchain_agent/prompts.py Updated REQUIRED_PROMPT_ENDING_FOR_MICROCHAIN constant to include a new instruction for error reporting

The specific addition to the prompt is:

If some function errors out, include the exact function and arguments you tried to call in your follow-up reasoning call.

This change modifies the system prompt's error handling guidance without altering the overall structure of the code.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
prediction_market_agent/agents/microchain_agent/prompts.py (1)

43-43: Consider adding an example format for consistency.

While the instruction is clear, providing an example format could ensure consistent error reporting across different scenarios.

Consider expanding the instruction like this:

-If some function errors out, include the exact function and arguments you tried to call in your follow-up reasoning call.
+If some function errors out, include the exact function and arguments you tried to call in your follow-up reasoning call. For example: "Previous call that failed: GetMarkets(limit=5)".
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2189f11 and dab05fe.

📒 Files selected for processing (1)
  • prediction_market_agent/agents/microchain_agent/prompts.py (1 hunks)
🔇 Additional comments (1)
prediction_market_agent/agents/microchain_agent/prompts.py (1)

43-43: Great addition for improving error traceability!

This enhancement will make debugging easier by ensuring that failed function calls are properly documented in the reasoning history.

@kongzii kongzii merged commit 12274c5 into main Jan 20, 2025
10 checks passed
@kongzii kongzii deleted the peter/showerroredfunction branch January 20, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants