Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for intervals in postgres #406

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

safaci2000
Copy link
Contributor

Fixes #393

@safaci2000
Copy link
Contributor Author

Blocked by testdata PR and builds on top of #404.

@safaci2000 safaci2000 force-pushed the feature/intervalSubmission branch from aced029 to 2a3fafd Compare October 7, 2024 19:27
@safaci2000 safaci2000 marked this pull request as draft October 7, 2024 20:16
@safaci2000 safaci2000 force-pushed the feature/intervalSubmission branch 12 times, most recently from d8407ab to 7e01e4d Compare October 8, 2024 00:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (c30a350) to head (c0a0b45).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #406   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files         126      126           
  Lines        7434     7441    +7     
=======================================
+ Hits         6730     6737    +7     
  Misses        545      545           
  Partials      159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@safaci2000 safaci2000 force-pushed the feature/intervalSubmission branch 2 times, most recently from d0c5558 to 6675f5a Compare October 8, 2024 00:35
@safaci2000 safaci2000 marked this pull request as ready for review October 8, 2024 00:36
@safaci2000 safaci2000 force-pushed the feature/intervalSubmission branch from 6675f5a to f4e07ea Compare October 8, 2024 00:36
@safaci2000 safaci2000 force-pushed the feature/intervalSubmission branch from f4e07ea to 288ebdc Compare October 8, 2024 12:30
@go-jet
Copy link
Owner

go-jet commented Oct 10, 2024

Thanks. Looks good. 👍

@go-jet go-jet merged commit f9358ca into go-jet:master Oct 10, 2024
3 checks passed
@safaci2000 safaci2000 deleted the feature/intervalSubmission branch October 10, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Support for Postgres Interval
3 participants