Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ruleset): add dynamic evaluation with expr #1233

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JordanSussman
Copy link
Collaborator

@JordanSussman JordanSussman commented Dec 31, 2024

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (794c666) to head (cb24e66).

Files with missing lines Patch % Lines
compiler/types/pipeline/ruleset.go 6.66% 13 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   56.61%   56.59%   -0.03%     
==========================================
  Files         626      626              
  Lines       35495    35509      +14     
==========================================
  Hits        20096    20096              
- Misses      14720    14733      +13     
- Partials      679      680       +1     
Files with missing lines Coverage Δ
compiler/native/compile.go 69.21% <100.00%> (ø)
compiler/types/pipeline/build.go 72.72% <100.00%> (ø)
compiler/types/pipeline/container.go 82.91% <100.00%> (ø)
compiler/types/pipeline/secret.go 94.59% <100.00%> (ø)
compiler/types/pipeline/stage.go 96.34% <100.00%> (ø)
compiler/types/pipeline/ruleset.go 71.68% <6.66%> (-6.61%) ⬇️

@JordanSussman JordanSussman changed the title wip feat(ruleset): add dynamic evaluation with expr Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant