Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): use Config instead of ConfigBackoff when fetching deploy config #1239

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

ecrupper
Copy link
Contributor

users supplying a bad ref should not result in a several second response time. the backoff is only helpful when dealing with concurrent webhooks with legit refs

@ecrupper ecrupper requested a review from a team as a code owner January 10, 2025 17:11
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3rw3rk wass3rw3rk merged commit fb2f8cf into main Jan 10, 2025
11 of 12 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/no-deploy-config-backoff branch January 10, 2025 17:25
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.56%. Comparing base (7d74bfc) to head (4611894).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/deployment/get_config.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1239   +/-   ##
=======================================
  Coverage   56.56%   56.56%           
=======================================
  Files         629      629           
  Lines       35609    35609           
=======================================
  Hits        20144    20144           
  Misses      14784    14784           
  Partials      681      681           
Files with missing lines Coverage Δ
api/deployment/get_config.go 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants