-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PD after the initial configuration #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing the realloc() bug, and fixing the broken code formatting (see style guide), I will take a closer look at this PR.
Please add some motivation/problem-statement which lead you to make this change. PDs don't need to be added at runtime in most cases. Knowing why you are doing what you are doing, helps me better evaluate your change. |
Hi, thanks for your time. |
7df7634
to
1d2868e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posting these comments just for posterity. Most of these are nits, and since I was already reviewing them locally, just decided to address them locally to avoid a back-and-forth.
bb9ebcd
to
acd2334
Compare
Signed-off-by: Nicholas Hahn <[email protected]> Signed-off-by: Siddharth Chandrasekaran <[email protected]>
0659ba6
to
c41c77a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Thanks for your help, time and kindly review. |
Add the capability to add PD's in the CP after the initial initialization.
This can be used to add devices in run time.