Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm build packages #667

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Mar 15, 2024

Summary

This PR updates npm dependencies that are used in the FW to build its static assets, generate the potfile, compile scss and coffeescript, webpack, etc.

This should address some security warnings although the dependencies per se are not part of the distribution so there are no security risks involved.

I was hoping it would have addressed the issue with #360 however it turns out the output is still problematic and likely an issue with the grunt-contrib-sass package. I'll open an issue there to ask for configuration options (update: issue opened gruntjs/grunt-contrib-sass#283).

For now I have manually edited the affected map file references, but there changes would be reverted if we are to build again those css files (does not happen that frequently).

Closes #360 (see above caveats though, will require follow up)

would also close several open prs: https://github.com/godaddy-wordpress/wc-plugin-framework/pulls?q=is:pr+is:open+sort:updated-desc

QA

To test these changes, the reviewer should run this version of the FW with a gateway that uses the payment form and account payment methods, ensuring the functionality and CSS is unaltered.

Copy link
Contributor

@itambek-godaddy itambek-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this branch on Cybersource, and was able to checkout and add payment methods on the My Account page successfully. No visual differences detected, either.

@unfulvio-godaddy unfulvio-godaddy merged commit 0e25ac6 into master Mar 18, 2024
@unfulvio-godaddy unfulvio-godaddy deleted the chore/update-build-packages branch March 18, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source map is not included in the package but is referenced by the min file
3 participants