Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates npm dependencies that are used in the FW to build its static assets, generate the potfile, compile scss and coffeescript, webpack, etc.
This should address some security warnings although the dependencies per se are not part of the distribution so there are no security risks involved.
I was hoping it would have addressed the issue with #360 however it turns out the output is still problematic and likely an issue with the
grunt-contrib-sass
package. I'll open an issue there to ask for configuration options (update: issue opened gruntjs/grunt-contrib-sass#283).For now I have manually edited the affected map file references, but there changes would be reverted if we are to build again those css files (does not happen that frequently).
Closes #360 (see above caveats though, will require follow up)
would also close several open prs: https://github.com/godaddy-wordpress/wc-plugin-framework/pulls?q=is:pr+is:open+sort:updated-desc
QA
To test these changes, the reviewer should run this version of the FW with a gateway that uses the payment form and account payment methods, ensuring the functionality and CSS is unaltered.