Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize lightclient #24

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Dockerize lightclient #24

merged 7 commits into from
Jan 15, 2025

Conversation

udit-gulati
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

Signed-off-by: udit-gulati <[email protected]>
@udit-gulati udit-gulati requested a review from a team as a code owner January 13, 2025 12:37
Copy link
Contributor

@vuvoth vuvoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments or instructions about how to use and build this in README.
Can you configure the path to the data file via docker env?

Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving.

Dockerfile Outdated Show resolved Hide resolved
@udit-gulati udit-gulati merged commit 30187fb into master Jan 15, 2025
11 checks passed
@udit-gulati udit-gulati deleted the udit/dockerize branch January 15, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants