Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactore: move ika client to ika package #36

Merged
merged 1 commit into from
Nov 26, 2024
Merged

refactore: move ika client to ika package #36

merged 1 commit into from
Nov 26, 2024

Conversation

robert-zaremba
Copy link
Contributor

@robert-zaremba robert-zaremba commented Nov 25, 2024 •
edited
Loading

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

sczembor
sczembor approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@robert-zaremba robert-zaremba merged commit a8ea533 into master Nov 26, 2024
9 of 13 checks passed
@robert-zaremba robert-zaremba deleted the robert/clenaup branch November 26, 2024 12:06
udit-gulati pushed a commit that referenced this pull request Dec 2, 2024
@robert-zaremba @udit-gulati
refactore: move ika client to ika package (#36)
f6c90fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczembor sczembor sczembor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert-zaremba @sczembor