Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tutorial for btcd simnet #51

Merged
merged 11 commits into from
Dec 16, 2024
Merged

feat: tutorial for btcd simnet #51

merged 11 commits into from
Dec 16, 2024

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Dec 10, 2024

Description

This is basic command line to start btc simnet.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Show resolved Hide resolved
contrib/README.md Show resolved Hide resolved
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move it to docs directory as a separate file. we can link it here to there

Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can run markdownlint-cli2 --fix <filename> to automatically fix the linter issues

@vuvoth
Copy link
Contributor Author

vuvoth commented Dec 11, 2024

I suggest to move it to docs directory as a separate file. we can link it here to there

I think we should keep it here and link from the doc to this folder. To make the development flow easier, we will add a Docker or script to this folder. So, this makes more sense if the document and script or Docker file are in the same folder.

.gitignore Outdated Show resolved Hide resolved
contrib/README.md Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
@vuvoth vuvoth enabled auto-merge (squash) December 16, 2024 07:37
vuvoth and others added 11 commits December 16, 2024 14:39
Signed-off-by: Vu Vo <[email protected]>
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.9.0 to 0.10.0.
- [Commits](golang/sync@v0.9.0...v0.10.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.68.0 to 1.68.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.68.0...v1.68.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Robert Zaremba <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
* db docs + flow chart

Signed-off-by: sczembor <[email protected]>

* Apply suggestions from code review

Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Vu Vo <[email protected]>
Signed-off-by: sczembor <[email protected]>

* add docs dir and move part of the documentation from readme

Signed-off-by: sczembor <[email protected]>

---------

Signed-off-by: sczembor <[email protected]>
Signed-off-by: sczembor <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Vu Vo <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
* approveAndSign implementation + test

Signed-off-by: sczembor <[email protected]>

* linter

Signed-off-by: sczembor <[email protected]>

* Update ika/client.go

Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: sczembor <[email protected]>

* move error loging higher, wrap errors to add more context

Signed-off-by: sczembor <[email protected]>

* add test

Signed-off-by: sczembor <[email protected]>

* skip the test;add info

Signed-off-by: sczembor <[email protected]>

* add dwallet package fields to ika client

Signed-off-by: sczembor <[email protected]>

---------

Signed-off-by: sczembor <[email protected]>
Signed-off-by: sczembor <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Co-authored-by: Udit Gulati <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
@vuvoth vuvoth merged commit db7c976 into master Dec 16, 2024
11 checks passed
@vuvoth vuvoth deleted the vu/btc-simnet branch December 16, 2024 07:42
udit-gulati added a commit that referenced this pull request Dec 16, 2024
* init docker file

Signed-off-by: Vu Vo <[email protected]>

* Tutorial for btcd simnet

Signed-off-by: Vu Vo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Udit Gulati <[email protected]>
Signed-off-by: Vu Vo <[email protected]>

* apply markdownlint-cli2

Signed-off-by: Vu Vo <[email protected]>

* fix lint

Signed-off-by: Vu Vo <[email protected]>

* Apply suggestions from code review

Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Vu Vo <[email protected]>

* update PR

Signed-off-by: Vu Vo <[email protected]>

---------

Signed-off-by: Vu Vo <[email protected]>
Co-authored-by: Udit Gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants