Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relayer: Ika signature logic #52

Merged
merged 30 commits into from
Dec 19, 2024
Merged

Relayer: Ika signature logic #52

merged 30 commits into from
Dec 19, 2024

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Dec 11, 2024 •
edited
Loading

Description

Code containing the nativeProcessor and database logic for storing the nativeTx before processing by the relayer and keeping track of what has and what hasnt been processed yet.

Closes: #31 #61 #29

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

@sczembor
add processor logic for signing native signatures in ika; add new tx …
b7ee25c 
…status: ; add test; add ika client interface; add ika client mock

Signed-off-by: sczembor <[email protected]>
@sczembor sczembor requested a review from vuvoth December 11, 2024 16:26
@sczembor
fix linter
8568691 
Signed-off-by: sczembor <[email protected]>
vuvoth
vuvoth reviewed Dec 11, 2024
View reviewed changes
ika/client.go Outdated Show resolved Hide resolved
processor/processor.go Outdated Show resolved Hide resolved
processor/processor.go Outdated Show resolved Hide resolved
processor/processor.go Outdated Show resolved Hide resolved
@sczembor sczembor mentioned this pull request Dec 16, 2024
Closed
sczembor
sczembor commented Dec 16, 2024
View reviewed changes
native2ika/processor.go Outdated Show resolved Hide resolved
@sczembor sczembor marked this pull request as ready for review December 16, 2024 09:04
@sczembor sczembor requested a review from vuvoth December 16, 2024 09:04
vuvoth
vuvoth reviewed Dec 16, 2024
View reviewed changes
dal/db.go Outdated Show resolved Hide resolved
native2ika/processor.go Outdated Show resolved Hide resolved
robert-zaremba
robert-zaremba reviewed Dec 16, 2024
View reviewed changes
ika/client.go Outdated Show resolved Hide resolved
ika/client_mock.go Show resolved Hide resolved
native2ika/processor_test.go Show resolved Hide resolved
native2ika/processor_test.go Show resolved Hide resolved
sczembor and others added 8 commits December 17, 2024 09:39
vuvoth
vuvoth approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@vuvoth vuvoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait for @robert-zaremba's final review!

robert-zaremba
robert-zaremba reviewed Dec 18, 2024
View reviewed changes
dal/db.go Outdated Show resolved Hide resolved
dal/db.go Outdated Show resolved Hide resolved
dal/db.go Outdated Show resolved Hide resolved
sczembor and others added 8 commits December 19, 2024 15:06
robert-zaremba
robert-zaremba approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, added few suggestions. pre-approving

dal/db.go Show resolved Hide resolved
dal/db.go Show resolved Hide resolved
dal/db.go Outdated Show resolved Hide resolved
dal/db.go Outdated Show resolved Hide resolved
dal/db.go Outdated Show resolved Hide resolved
native2ika/processor.go Outdated Show resolved Hide resolved
native2ika/processor.go Outdated Show resolved Hide resolved
native2ika/processor_test.go Outdated Show resolved Hide resolved
native2ika/processor_test.go Show resolved Hide resolved
nbtc/relayer_test.go Outdated Show resolved Hide resolved
sczembor
sczembor commented Dec 19, 2024
View reviewed changes
dal/db.go Show resolved Hide resolved
@sczembor
Update dal/db.go
31cd7bc 
Signed-off-by: sczembor <[email protected]>
@sczembor sczembor enabled auto-merge (squash) December 19, 2024 22:52
@sczembor sczembor merged commit c420475 into master Dec 19, 2024
11 checks passed
@sczembor sczembor deleted the stan/31-ika-signature-logic branch December 19, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@vuvoth vuvoth vuvoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native->Bitcoin relayer: Implement Ika signature logic
3 participants
@sczembor @robert-zaremba @vuvoth