-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitcoin SPV relayer: Relays blocks from Bitcoin to Native #56
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to split this PR into 2.
Also, as noted, we can't simply copy-paste babylon code.
- name: Install dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install -y libzmq3-dev pkg-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a pure go version of zmq?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found https://github.com/go-zeromq/zmq4
NOt sure if it'll be compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test and let's see.
As noted last week, we need to add comments in the PR to the code that is "ours" to see what code is copied . |
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]> Signed-off-by: Udit Gulati <[email protected]>
…tclient Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
… proof of each txn and submitting it to the lightclient Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
…rge extract and submit transaction into one function Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
d94944f
to
05c256d
Compare
…l cleanups of logging and sample config file Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
we need to do refactoring. Jan 16 |
Signed-off-by: udit-gulati <[email protected]>
Description
Bitcoin -> Native blocks relayer
This new PR created because previous one #34 got messed up after multiple rebase from
master
branch.Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md