Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin SPV relayer: Relays blocks from Bitcoin to Native #56

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

udit-gulati
Copy link
Contributor

Description

Bitcoin -> Native blocks relayer

This new PR created because previous one #34 got messed up after multiple rebase from master branch.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to split this PR into 2.
Also, as noted, we can't simply copy-paste babylon code.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install -y libzmq3-dev pkg-config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a pure go version of zmq?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found https://github.com/go-zeromq/zmq4

NOt sure if it'll be compatible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test and let's see.

btcclient/client.go Show resolved Hide resolved
@robert-zaremba
Copy link
Contributor

As noted last week, we need to add comments in the PR to the code that is "ours" to see what code is copied .

udit-gulati and others added 24 commits January 6, 2025 17:36
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Signed-off-by: Udit Gulati <[email protected]>
… proof of each txn and submitting it to the lightclient

Signed-off-by: udit-gulati <[email protected]>
…rge extract and submit transaction into one function

Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
…l cleanups of logging and sample config file

Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
Signed-off-by: udit-gulati <[email protected]>
@robert-zaremba
Copy link
Contributor

robert-zaremba commented Jan 13, 2025

we need to do refactoring. Jan 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants