Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/docker bitcoind regest mode #60

Merged
merged 5 commits into from
Dec 17, 2024
Merged

feat/docker bitcoind regest mode #60

merged 5 commits into from
Dec 17, 2024

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Dec 17, 2024

Description

Closes: #XXXX


Add a makefile script to run and manage the bitcoind node in docker.
Notes: This is run in regtest mode for development only.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

contrib/snapshot/bitcoin.conf Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
contrib/MockBitcoind.md Outdated Show resolved Hide resolved
contrib/MockBitcoind.md Outdated Show resolved Hide resolved
contrib/MockBitcoind.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left few suggestions

vuvoth and others added 2 commits December 17, 2024 21:18
@vuvoth vuvoth merged commit 31c4ed7 into master Dec 17, 2024
11 checks passed
@vuvoth vuvoth deleted the feat/docker-bitcoind branch December 17, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants