Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relayer: CLI tool #85

Merged
merged 28 commits into from
Jan 15, 2025
Merged

Relayer: CLI tool #85

merged 28 commits into from
Jan 15, 2025

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Jan 9, 2025 •
edited
Loading

Description

CMD tool for starting the relayer

Closes: #78

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

@sczembor sczembor changed the title Relayer: cli tool Relayer: CLI tool Jan 9, 2025
@sczembor sczembor marked this pull request as ready for review January 10, 2025 15:28
udit-gulati
udit-gulati requested changes Jan 10, 2025
View reviewed changes
cmd/native-relayer/cli/root.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/stop.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/utils.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/utils.go Outdated Show resolved Hide resolved
cmd/native-relayer/config.yaml Outdated Show resolved Hide resolved
cmd/native-relayer/config.yaml Outdated Show resolved Hide resolved
sczembor and others added 3 commits January 10, 2025 16:47
@sczembor @udit-gulati
Apply suggestions from code review
ac7df82 
Co-authored-by: Udit Gulati <[email protected]>
Signed-off-by: sczembor <[email protected]>
@sczembor
apply code review suggestions
f5f3d66 
Signed-off-by: sczembor <[email protected]>
@sczembor
apply code review suggestions
f20c994 
Signed-off-by: sczembor <[email protected]>
@sczembor sczembor requested a review from udit-gulati January 10, 2025 16:04
robert-zaremba
robert-zaremba reviewed Jan 13, 2025
View reviewed changes
cmd/native-relayer/cli/config.go Show resolved Hide resolved
cmd/native-relayer/cli/root.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/stop.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/utils.go Show resolved Hide resolved
cmd/native-relayer/config.yaml Outdated Show resolved Hide resolved
vuvoth
vuvoth reviewed Jan 13, 2025
View reviewed changes
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/config.yaml Outdated Show resolved Hide resolved
robert-zaremba
robert-zaremba reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update the structure of the code, the 'Run' function (cmd) is too long and to many things are there.

cmd/native-relayer/cli/config.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Outdated Show resolved Hide resolved
cmd/native-relayer/cli/start.go Show resolved Hide resolved
cmd/native-relayer/config.yaml Outdated Show resolved Hide resolved
nbtc/relayer.go Outdated Show resolved Hide resolved
sczembor and others added 7 commits January 14, 2025 11:56
robert-zaremba
robert-zaremba approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

cmd/native-relayer/cli/start.go Show resolved Hide resolved
cmd/native-relayer/config.yaml Outdated Show resolved Hide resolved
@sczembor sczembor enabled auto-merge (squash) January 14, 2025 23:28
@sczembor sczembor merged commit c447bbb into master Jan 15, 2025
10 checks passed
@sczembor sczembor deleted the stan/78-cmd branch January 15, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuvoth vuvoth vuvoth left review comments

@udit-gulati udit-gulati udit-gulati approved these changes

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native->Bitcoin relayer: updated cmd package to correctly start all relayers
4 participants
@sczembor @robert-zaremba @vuvoth @udit-gulati