Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create and extract fork script #94

Merged
merged 8 commits into from
Jan 17, 2025
Merged

feat: create and extract fork script #94

merged 8 commits into from
Jan 17, 2025

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Jan 16, 2025

Description

  • Create a fork from snapshot
  • Extract block header for testing

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary

vuvoth added 4 commits January 16, 2025 18:38
@vuvoth
basic sctipt for create fork
cf6aff3 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
runable extract script
28c5fb9 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
fork name
1a54b5d 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth
update docs
f7a8bef 
Signed-off-by: Vu Vo <[email protected]>
@vuvoth vuvoth enabled auto-merge (squash) January 16, 2025 16:28
sczembor
sczembor reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .md needs a little work, I provided some comments

contrib/bitcoin-mock.md Outdated Show resolved Hide resolved
contrib/bitcoin-mock.md Outdated Show resolved Hide resolved
contrib/bitcoin-mock.md Outdated Show resolved Hide resolved
@vuvoth @sczembor
Apply suggestions from code review
aea452a 
Co-authored-by: sczembor <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
sczembor
sczembor approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

contrib/bitcoin-mock.md Outdated Show resolved Hide resolved
contrib/bitcoin-mock.md Outdated Show resolved Hide resolved
@vuvoth @sczembor
Apply suggestions from code review
6a4d572 
Co-authored-by: sczembor <[email protected]>
Signed-off-by: Vu Vo <[email protected]>
@vuvoth vuvoth merged commit 9a78a19 into master Jan 17, 2025
10 of 11 checks passed
@vuvoth vuvoth deleted the feat/vu-create-fork-script branch January 17, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczembor sczembor sczembor approved these changes

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@udit-gulati udit-gulati Awaiting requested review from udit-gulati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuvoth @sczembor