feat(sync-utils): set document ID in Sanity to match shopifyId #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This will be very helpful ~ I'm going to run a test locally to make sure there are no breaking changes to existing IDs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #165
This commit sets the document ID in Sanity for newly created documents to be the same as the ShopifyID.
The only difference between the ID's is the
=from the ShopifyID is removed as this fails validation on Sanity's end.Existing documents are not changed.
Doing this allows us to use the
IDFilterwhen performing aShopifyProductquery on Sanity using GraphQl with an ID returned directly from Shopify, for example when loading a users checkout.It would make sense to handle Collection ID's in the same way. Happy to create a PR for that too.