Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal LE Audio implementation #308

Closed
wants to merge 4 commits into from
Closed

Minimal LE Audio implementation #308

wants to merge 4 commits into from

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Oct 3, 2023

With the example, it can "cheat" Android source that Bumble is an available sink. However, volume control somehow doesn't work anymore.

@zxzxwu zxzxwu force-pushed the lea branch 4 times, most recently from 5cd6eea to fa77dc4 Compare October 3, 2023 09:38
@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Oct 3, 2023

@zxzxwu zxzxwu marked this pull request as draft October 11, 2023 17:13
@zxzxwu zxzxwu force-pushed the lea branch 10 times, most recently from 17c8c18 to 262b67a Compare November 24, 2023 15:57
@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Nov 24, 2023

I am hesitating because LEA services are not "profiles" - but actually they are separated as several profiles like BAP, CAP, CSIP, so maybe we should name modules after profiles instead of services?

bumble/gatt.py Outdated Show resolved Hide resolved
bumble/profiles/pacs.py Outdated Show resolved Hide resolved
bumble/profiles/pacs.py Outdated Show resolved Hide resolved
bumble/profiles/pacs.py Outdated Show resolved Hide resolved
bumble/profiles/pacs.py Outdated Show resolved Hide resolved
bumble/profiles/pacs.py Outdated Show resolved Hide resolved
bumble/profiles/csis.py Outdated Show resolved Hide resolved
class ServiceProxy(gatt_client.ProfileServiceProxy):
SERVICE_CLASS = Service

sirk: gatt_client.CharacteristicProxy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has been copy/pasted by mistake from another profile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, why do you think so?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The characteristics in the ServiceProxy here aren't the ones from the Service above, but they look like the ones from csis.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants