Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove characteristic in GATT Client unsubscribe() if it's the last subscriber #579

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Remove characteristic in GATT Client unsubscribe() if it's the last subscriber #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bumble/gatt_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,12 @@ async def unsubscribe(
) and subscriber in subscribers:
subscribers.remove(subscriber)

# The characteristic itself is added as subscriber. If it is the
# last remaining subscriber, we remove it, such that the clean up
# works correctly. Otherwise the CCCD never is set back to 0.
if len(subscribers) == 1 and characteristic in subscribers:
subscribers.remove(characteristic)

# Cleanup if we removed the last one
if not subscribers:
del subscriber_set[characteristic.handle]
Expand Down
Loading