chore: update main-swift branch from main branch
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when subclassing GMSMarker with a custom iconView, the iconView would not display on the map. This update enables custom iconViews to render correctly when using GMSMarker subclasses.
* chore(main): release 6.1.0 * chore(release-please--branches--main): Patch to release branch 6.1.0 (#509) --------- Co-authored-by: Subhodip Banerjee <[email protected]>
iHackSubhodip
commented
Jan 21, 2025
| @@ -41,7 +41,7 @@ jobs: | |||
| - name: Set Xcode version | |||
| uses: maxim-lobanov/setup-xcode@v1 | |||
| with: | |||
| xcode-version: latest-stable | |||
| xcode-version: "16.1" | |||
There was a problem hiding this comment.
[self-review]
What?
- This change should not be in as part of this PR. As, I just want to update
main-swiftbranch frommainbranch. - This should be latest Xcode 16.2[
xcode-version: latest-stable]. With the latest version the CI is failing. Attaching the CI job for reference. [https://github.com/googlemaps/google-maps-ios-utils/actions/runs/12890243952/job/35939379429]
Why? [Failure Reason]
- The CI is failing with latest Xcode.
- with Xcode 16.2 version, I don't see any required simulators in the Github CI.
How?
- Changing it to the previous Xcode version, making the CI success.
- The correct fix should be making the required simulator available for Xcode 16.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing?
main-swiftbranch frommainbranch