This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
LabelFilters: Fix bug with running incomplete query #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
reviewed
Jan 24, 2024
| @@ -14,7 +14,7 @@ interface Props { | |||
| defaultOp: string; | |||
| item: Partial<QueryBuilderLabelFilter>; | |||
| items: Array<Partial<QueryBuilderLabelFilter>>; | |||
| onChange: (value: QueryBuilderLabelFilter) => void; | |||
| onChange: (value: Partial<QueryBuilderLabelFilter>) => void; | |||
There was a problem hiding this comment.
I can't really see why it's Partial for all item, items, and onChange.
There was a problem hiding this comment.
Can you elaborate? Not sure I understand.
There was a problem hiding this comment.
I see at the bottom we call onChange sometimes without value, and sometimes without value. Again not sure why, but that explains the partial.
matyax
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
LabelFilterItemwe incorrectly assumed that the type ofonChangeisonChange: (value: Partial<QueryBuilderLabelFilter>) => void; and to fix types assertion, I defaulted to empty string. Which is incorrect and was causing updating of query after each part of label filter changed. But we want to update query only after all parts of label filter are updated.Also correct type for
OnChangeinLabelFilterItemshould be withPartial