This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Visual query builder: Update e2e selectors #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohandley
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Yes! Good find on the e2e selectors that I changed in late November. Sorry about that
More recently, I was working on Prometheus e2e tests and made sure sure not to change any other shared e2e selectors for shared code. After I complete the migration of the Prometheus library and use the shared folder, I may go back into the shared folder and add more selectors. I will not do that until Prometheus is using this location for the shared folder.
Thank you for finding this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Trough the migration of visual query builder to this repository, grafana/grafana#78554 was merged which changes code related to e2e tests - instead of
aria labelsit usesdata-testidinLabelFilterItem.This caused the issue with e2e where I couldn't merge grafana/grafana#81380 as e2e test was failing.
In this PR I am:
@grafana/e2e-selectorsas peer and dev dependency as it is with@grafana/data,@grafana/ui, ...inputIdsweren't unique, so I updated the logicuseRefto keepidsconsistent and not change on every re-renderDataQueryfrom@grafana/data. If we want to use it in the future fromschema, we need to add it as dev/peer dependency.Passing e2e test with updated component:
e2e.mov