Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Bump @grafana dependencies and React to 18 #127

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Bump @grafana dependencies and React to 18 #127

merged 6 commits into from
Sep 6, 2024

Conversation

idastambuk
Copy link
Contributor

@idastambuk idastambuk commented Aug 7, 2024

  • Bumps grafana dependencies to the 10.4
  • Bumps grafana peer dependencies to 10.4
  • Bumps React to 18 to be compatible with latest grafana version
  • Bump some other dev dependencies to be compatible with new grafana dependencies' version

@idastambuk idastambuk changed the title Bumps @grafana dependencies and React to 18 Bump @grafana dependencies and React to 18 Aug 7, 2024
@ivanahuckova
Copy link
Member

Woohoo! I'll test locally and review, but in the meantime, it looks like we need to bump the node versions in our github actions https://github.com/grafana/grafana-experimental/blob/main/.github/workflows/publish-npm.yml and https://github.com/grafana/grafana-experimental/blob/main/.github/workflows/ci.yml

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me! Code changes look good. I have also tested with yugabyte and with Loki and all seems to work as expected. I didn't press approve, cause @cletter7 should verify this change in https://github.com/grafana/plugins-private/pull/2352 to see if it solves the issues.

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested with yugabyte (as external data source) and in grafana/grafana and everything works as expected. So I think we can go ahead an merge + release this.

@ivanahuckova
Copy link
Member

Next step is to also remove all occurrences of React.FC

@idastambuk idastambuk requested a review from a team as a code owner August 27, 2024 12:22
@idastambuk idastambuk requested review from yesoreyeram and removed request for a team August 27, 2024 12:22
@ivanahuckova
Copy link
Member

I have tested it again with grafana repository and core data sources, json data source(randomly chosen old plugin), yugabyte (randomly chosen new data source) and could not reproduce any issue. So again LGTM from me also after last change.

@idastambuk idastambuk merged commit 1fc652e into main Sep 6, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants