-
Notifications
You must be signed in to change notification settings - Fork 5
Bump @grafana dependencies and React to 18 #127
Conversation
idastambuk
commented
Aug 7, 2024
•
edited by ivanahuckova
Loading
edited by ivanahuckova
- Bumps grafana dependencies to the 10.4
- Bumps grafana peer dependencies to 10.4
- Bumps React to 18 to be compatible with latest grafana version
- Bump some other dev dependencies to be compatible with new grafana dependencies' version
Woohoo! I'll test locally and review, but in the meantime, it looks like we need to bump the node versions in our github actions https://github.com/grafana/grafana-experimental/blob/main/.github/workflows/publish-npm.yml and https://github.com/grafana/grafana-experimental/blob/main/.github/workflows/ci.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me! Code changes look good. I have also tested with yugabyte and with Loki and all seems to work as expected. I didn't press approve, cause @cletter7 should verify this change in https://github.com/grafana/plugins-private/pull/2352 to see if it solves the issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested with yugabyte (as external data source) and in grafana/grafana and everything works as expected. So I think we can go ahead an merge + release this.
Next step is to also remove all occurrences of React.FC |
I have tested it again with grafana repository and core data sources, json data source(randomly chosen old plugin), yugabyte (randomly chosen new data source) and could not reproduce any issue. So again LGTM from me also after last change. |