Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add readiness probe for memcached #15609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LukoJy3D
Copy link
Contributor

@LukoJy3D LukoJy3D commented Jan 6, 2025

What this PR does / why we need it:
image

Special notes for your reviewer:
Probe values base on bitnami chart: https://github.com/bitnami/charts/blob/main/bitnami/memcached/values.yaml

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@LukoJy3D LukoJy3D requested a review from a team as a code owner January 6, 2025 15:57
@LukoJy3D LukoJy3D force-pushed the feat/add_readiness_probe_for_memcached branch from 06c7a8c to 5b0fd72 Compare January 6, 2025 18:19
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jan 6, 2025
@LukoJy3D LukoJy3D force-pushed the feat/add_readiness_probe_for_memcached branch from 5b0fd72 to 2d72d61 Compare January 6, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant