Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(partition-ingester): Add stream creation error logging #15640

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Jan 8, 2025

What this PR does / why we need it:
When using kafka-based ingestion we are missing currently to notify which streams are not created as per response path is asynchronous. This PR adds some short-term logging to inform investigators when and which streams were not created by the partition-ingesters on stream count limiting.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  • The partition ingesters have as of today disabled rate limiting.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Jan 8, 2025
@periklis periklis requested a review from a team as a code owner January 8, 2025 09:17
pkg/ingester/instance.go Outdated Show resolved Hide resolved
@periklis periklis merged commit f63c16f into main Jan 8, 2025
59 checks passed
@periklis periklis deleted the async-limits-logging branch January 8, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants