Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix only run on fork guard #15677

Merged
merged 1 commit into from
Jan 10, 2025
Merged

ci: Fix only run on fork guard #15677

merged 1 commit into from
Jan 10, 2025

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 10, 2025

What this PR does / why we need it:

The previous guard fails because github.repository resolves to the base repository on pull_request events.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

The previous guard fails because `github.repository` resolves to the base repository on `pull_request` events.

Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry requested a review from a team as a code owner January 10, 2025 10:50
@jdbaldry jdbaldry changed the title Fix only run on fork guard ci: Fix only run on fork guard Jan 10, 2025
@owen-d owen-d merged commit 89818b7 into main Jan 10, 2025
61 checks passed
@owen-d owen-d deleted the jdbaldry-patch-1 branch January 10, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants