Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Plugin: Introduce create plugin update workflow #1211

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Oct 11, 2024

What this PR does / why we need it:
This PR adds a template file for running the create plugin update composite workflow and additional documentation to the website.

Relies on grafana/plugin-actions/pull/38 being merged before this can be merged. The action is now merged.

Which issue(s) this PR fixes:

Fixes #818

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]

@jackw jackw added create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged labels Oct 11, 2024
@jackw jackw self-assigned this Oct 11, 2024
@jackw jackw requested a review from a team as a code owner October 11, 2024 13:50
@jackw jackw requested review from academo and removed request for a team October 11, 2024 13:50
Copy link

github-actions bot commented Oct 11, 2024

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Just an idea - would it make sense to add a note about the github token permissions into the print-success-message.ts?

@jackw
Copy link
Collaborator Author

jackw commented Oct 17, 2024

Just an idea - would it make sense to add a note about the github token permissions into the print-success-message.ts?

I think that's a great idea @leventebalogh ! 🚀

@jackw jackw merged commit 5904881 into main Oct 18, 2024
15 checks passed
@jackw jackw deleted the jackw/gh-cp-update-workflow branch October 18, 2024 07:14
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/[email protected], @grafana/[email protected] 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Oct 18, 2024
@jackw
Copy link
Collaborator Author

jackw commented Oct 18, 2024

I've opened #1241 for the success messaging @leventebalogh .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

Feat: GitHub action to run yarn create @grafana/plugin update
3 participants