[WIP] Add static labels to the CloudWatch jobs #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
andriikushch
changed the title
| @@ -82,6 +92,7 @@ resource "grafana_cloud_provider_aws_cloudwatch_scrape_job" "test" { | |||
| - `export_tags` (Boolean) When enabled, AWS resource tags are exported as Prometheus labels to metrics formatted as `aws_<service_name>_info`. | |||
| - `regions_subset_override` (Set of String) A subset of the regions that are configured in the associated AWS Account resource to apply to this scrape job. If not set or empty, all of the Account resource's regions are scraped. | |||
| - `service` (Block List) One or more configuration blocks to configure AWS services for the CloudWatch Scrape Job to scrape. Each block must have a distinct `name` attribute. When accessing this as an attribute reference, it is a list of objects. (see [below for nested schema](#nestedblock--service)) | |||
| - `static_labels` (Block List) Zero or more configuration blocks to configure static labels to add to all metrics exported by this scrape job. (see [below for nested schema](#nestedblock--static_labels)) | |||
There was a problem hiding this comment.
I think the name of the field needs to be static_label to match the TF config, going on what's in the examples. Same for the data source.
There was a problem hiding this comment.
@tristanburgess, you are right 👍 Nice catch!
| RegionsSubsetOverrideUsed bool `json:"regionsSubsetOverrideUsed"` | ||
| DisabledReason string `json:"disabledReason"` | ||
| Provenance string `json:"provenance"` | ||
| StaticLabels map[string]string `json:"staticLabels"` |
There was a problem hiding this comment.
nit: this should be moved to below the CustomNamespaces field, since it's not a "computed field beyond the original request", but instead is a field that is part of the original request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.