chore: update GitHub actions workflows #1806

tylervz · 2024-06-21T14:50:08Z

Update the GitHub actions workflows to use the latest version of multiple actions, including actions/checkout, actions/setup-java, actions/cache, and release-drafter/release-drafter:

https://github.com/actions/checkout/tags
https://github.com/actions/setup-java/tags
https://github.com/actions/cache?tab=readme-ov-file#v4
https://github.com/release-drafter/release-drafter/tags

tylervz · 2024-06-21T14:51:54Z

.github/workflows/gradle.yml

      - name: Run Build
        id: build
-        uses: gradle/gradle-build-action@v2
+        run: ./gradlew build


The gradle/actions/setup-gradle action replaces gradle/gradle-build-action.
Reference:
https://github.com/gradle/actions/tree/af6e5767241073b8ab20cc8cf7e95ec63fadc160/setup-gradle#the-setup-gradle-action

tylervz · 2024-06-21T14:54:13Z

.github/workflows/release-notes.yml

@@ -24,7 +24,7 @@ jobs:
        id: extract_branch
        run: echo "value=${GITHUB_REF:11}" >> $GITHUB_OUTPUT
      # If it has release drafter:
-      - uses: release-drafter/release-drafter@v5
+      - uses: release-drafter/release-drafter@v6


There are no breaking changes in this release:
https://github.com/release-drafter/release-drafter/releases/tag/v6.0.0

tylervz · 2024-06-21T14:57:21Z

I did not upgrade the "Build and install groovy (no docs)" step in groovy-joint-workflow.yml, because I did not see a suitable replacement using gradle/actions/setup-gradle@v3.

If I replaced it with gradle/actions/setup-gradle@v3 like so:

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3
with:
  build-scan-publish: true
  build-scan-terms-of-use-url: "https://gradle.com/terms-of-service"
  build-scan-terms-of-use-agree: "yes"
# Use the Gradle wrapper in the ../groovy directory
- name: Build and install groovy (no docs)
  run: |
    cd ../groovy
    ./gradlew install \
      -x groovydoc \
      -x javadoc \
      -x javadocAll \
      -x groovydocAll \
      -x asciidoc \
      -x docGDK
  env:
    GRADLE_SCANS_ACCEPT: yes
    GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}

Then the gradle/actions/setup-gradle@v3 step in the example above is useless since it is configuring Gradle in the root directory for optimal execution rather than the Gradle wrapper in ../groovy that is actually going to get used.

I do not see any inputs/parameters for gradle/actions/setup-gradle@v3 similar to build-root-directory to have it configure a Gradle wrapper in a directory other than the root directory.
https://github.com/gradle/actions/blob/main/setup-gradle/action.yml

Update: perhaps we should update the step to be the same as it is in grails-core?
https://github.com/grails/grails-core/blob/6.2.x/.github/workflows/groovy-joint-workflow.yml#L103-L119

# Conflicts: # gradle.properties

…ations (grails#1810) * javax to jakarta, groovy 4, spring framework 6 and spring boot 3 migrations --------- Co-authored-by: Mattias Reichel <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: puneetbehl <[email protected]> Co-authored-by: Puneet Behl <[email protected]> Co-authored-by: Guillermo Calvo <[email protected]> Co-authored-by: jhron <[email protected]> Co-authored-by: micronaut-build <[email protected]> Co-authored-by: Guillermo Calvo <[email protected]>

…rails#1817) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…1.9.0 (grails#1805) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… compatible version and remove unused (grails#1825)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency com.h2database:h2 to v2.3.232

…-core-jakarta (grails#1831)

…applications in gorm-hibernate5 (grails#1832)

Cleanup & fix annotation reading for classpath scanning

Revert classpath scanning change, use the same strategy as grails-core

…p-validate

Remove api dependency until groovy version stabilizes

remove groovy transitive dependency until groovy version stabilizes

dependency cleanup

Update groovy monorepo to v4.0.24

Updates since groovy 4.0.24 is released

Add back logic for groovy snapshot support

Update dependency gradle to v8.11

jamesfredley · 2024-11-13T18:57:46Z

@tylervz after #1849 has been merged, can you rebase this against 9.0.x?

tylervz · 2024-11-13T19:07:17Z

@jamesfredley yes, I can do that :)

Also update to develocity gradle plugin and related change to DEVELOCITY_* env vars.

tylervz · 2024-11-13T21:20:49Z

I've rebased my branch on 9.0.x. I'm going to close this pull request and open a new one requesting to be merged into 9.0.x.

puneetbehl added 3 commits November 7, 2023 18:14

New Baseline to Java 17 (grails#1765)

e3f03fb

Merge branch '8.0.x' into 9.0.x

bcf5c6a

Merge branch '8.0.x' into 9.0.x

b153bf0

grails-build added chore maintenance labels Jun 21, 2024

tylervz commented Jun 21, 2024

View reviewed changes

jamesfredley and others added 22 commits August 17, 2024 18:20

Merge branch '9.0.x' into jamesfredley/9.0.x-changes

4c03d83

# Conflicts: # gradle.properties

fix(deps): update dependency org.javassist:javassist to v3.30.2-ga (g…

cfcf0bf

…rails#1817) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency commons-validator:commons-validator to v…

3559ce2

…1.9.0 (grails#1805) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update plugin com.gradle.enterprise to v3.18 (grails#1804)

e617b52

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update spring core to v6.1.12 (grails#1803)

b2aba3e

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update spring core to v6.1.13 (grails#1820)

0dccb03

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update dependency gradle to v8.10.1 (grails#1818)

bca9656

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update plugin com.gradle.enterprise to v3.18.1 (grails#1819

9e9627f

) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update groovy monorepo to v4.0.23 (grails#1821)

3268c9b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Move all versions to gradle.properties, update dependencies to latest…

581b9e0

… compatible version and remove unused (grails#1825)

chore(deps): update dependency gradle to v8.10.2 (grails#1826)

c6d4573

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency com.h2database:h2 to v2.3.232

c314c9d

get rid of commons-lang

dc1dbf7

Merge pull request grails#1814 from grails/renovate/h2version

a97ed18

fix(deps): update dependency com.h2database:h2 to v2.3.232

el libraries are provided by container

04a321d

compileOnlyApi jakarta.el (grails#1829)

e4acaf8

Update to grails-async 6.0.0-SNAPSHOT, spring 6.1.14 and us hibernate…

1fe227f

…-core-jakarta (grails#1831)

restore required glassfish el implementation since it broke all test …

ceeb6fe

…applications in gorm-hibernate5 (grails#1832)

add grails-bom to resolve dependency versions

119f5ea

use Groovy 4.0.24-SNAPSHOT

9f1770f

restore domain inheritance tests

b13a33d

jdaugherty and others added 23 commits October 29, 2024 20:52

Fix grails#1155 - validate(args) should be consistent with validate()

41aeda8

Cleanup & fix annotation reading for classpath scanning

c8f7b0d

Merge pull request grails#1836 from jdaugherty/9.0.x

0cfee5f

Cleanup & fix annotation reading for classpath scanning

Revert classpath scanning change, use the same strategy as grails-core

42ca4a9

Merge pull request grails#1837 from jdaugherty/9.0.x

165eb79

Revert classpath scanning change, use the same strategy as grails-core

Merge branch '9.0.x' into feature/9.0.x/1155-skip-validate

ac3fb74

Merge pull request grails#1838 from jdaugherty/feature/9.0.x/1155-ski…

462fb19

…p-validate

Remove api dependency until groovy version stabilizes

83fd6de

Merge pull request grails#1839 from codeconsole/9.0.x-no-groovy-api

e6476c3

Remove api dependency until groovy version stabilizes

remove groovy transitive dependency until groovy version stabilizes

9f93975

Merge pull request grails#1840 from codeconsole/9.0.x-no-groovy-api

e94d5a5

remove groovy transitive dependency until groovy version stabilizes

dependency cleanup

badd26c

Merge pull request grails#1841 from codeconsole/9.0.x-bom-cleanup

a0f2c95

dependency cleanup

Merge branch '8.1.x' into 9.0.x

5094249

jdk 17

5629912

Update groovy monorepo to v4.0.24

9dbec11

Merge pull request grails#1842 from grails/renovate/groovy-monorepo

67b35ae

Update groovy monorepo to v4.0.24

Updates since groovy 4.0.24 is released

9099abc

Merge pull request grails#1843 from jdaugherty/9.0.x

ece45c5

Updates since groovy 4.0.24 is released

Add back logic for groovy snapshot support

8e4ef49

Merge pull request grails#1844 from jdaugherty/9.0.x

4cacca3

Add back logic for groovy snapshot support

Update dependency gradle to v8.11

a769b54

Merge pull request grails#1846 from grails/renovate/gradle-8.x

4e867b0

Update dependency gradle to v8.11

matrei and others added 2 commits November 13, 2024 21:56

ci: Update groovy-joint-workflow to use mavenLocal() (grails#1849)

d9493e5

Also update to develocity gradle plugin and related change to DEVELOCITY_* env vars.

chore: update GH actions workflows

66faa02

tylervz force-pushed the updateGhActions branch from aac8e09 to 66faa02 Compare November 13, 2024 21:18

tylervz closed this Nov 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update GitHub actions workflows #1806

chore: update GitHub actions workflows #1806

tylervz commented Jun 21, 2024

tylervz Jun 21, 2024

tylervz Jun 21, 2024

tylervz commented Jun 21, 2024 •

edited

Loading

jamesfredley commented Nov 13, 2024

tylervz commented Nov 13, 2024

tylervz commented Nov 13, 2024

chore: update GitHub actions workflows #1806

chore: update GitHub actions workflows #1806

Conversation

tylervz commented Jun 21, 2024

tylervz Jun 21, 2024

Choose a reason for hiding this comment

tylervz Jun 21, 2024

Choose a reason for hiding this comment

tylervz commented Jun 21, 2024 • edited Loading

jamesfredley commented Nov 13, 2024

tylervz commented Nov 13, 2024

tylervz commented Nov 13, 2024

tylervz commented Jun 21, 2024 •

edited

Loading