parameterize make command

graphsense · Jan 25, 2024 · b5eff39 · b5eff39
1 parent 4282c04
commit b5eff39
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 23 deletions.
diff --git a/Makefile b/Makefile
@@ -3,7 +3,7 @@ generate-openapi-client:
 		-v "${PWD}:/build:Z" \
 		-v "${PWD}/templates:/templates:Z" \
 		openapitools/openapi-generator-cli:v5.2.1 \
-		generate -i "https://api.test.ikna.io/openapi.json" \
+		generate -i "$(GS_REST_SERVICE_URL)/openapi.json" \
 		-g python \
 		-t /templates \
 		-o /build \

diff --git a/README.md b/README.md
@@ -220,16 +220,6 @@ Run the jupyter notebooks
 This python package has been generated from [Graphsense's OpenAPI specification](https://api.test.ikna.io) hosted by [Iknaio Cryptoasset Analytics GmbH](https://ikna.io) using this command:
 
 ```
-    docker run --rm \
-      -v "${PWD}:/build" \
-      -v "${PWD}/templates:/templates" \
-      openapitools/openapi-generator-cli:v5.2.1 \
-      generate -i "https://api.test.ikna.io/openapi.json" \
-        -g python \
-        -t /templates \
-        -o /build \
-        --additional-properties=packageName=graphsense \
-        --additional-properties=projectName=graphsense-python
-
+make GS_REST_SERVICE_URL="https://api.test.ikna.io" generate-openapi-client
 ```
 
diff --git a/templates/README.mustache b/templates/README.mustache
@@ -59,16 +59,6 @@ Please follow the [installation procedure](#installation--usage) and then run th
 This python package has been generated from [Graphsense's OpenAPI specification]({{basePath}}) hosted by [Iknaio Cryptoasset Analytics GmbH](https://ikna.io) using this command:
 
 ```
-    docker run --rm \
-      -v "${PWD}:/build" \
-      -v "${PWD}/templates:/templates" \
-      openapitools/openapi-generator-cli:v5.2.1 \
-      generate -i "{{inputSpec}}" \
-        -g python \
-        -t /templates \
-        -o /build \
-        --additional-properties=packageName=graphsense \
-        --additional-properties=projectName=graphsense-python
-
+make GS_REST_SERVICE_URL="{{basePath}}" generate-openapi-client
 ```