Consolidating slice to pointer slice functions #50651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvbrock
added
the
no-changelog
strideynet
reviewed
Dec 31, 2024
zmb3
reviewed
Dec 31, 2024
zmb3
approved these changes
Dec 31, 2024
Co-authored-by: Zac Bergquist <[email protected]>
tigrato
approved these changes
Jan 2, 2025
public-teleport-github-review-bot
bot
removed the request for review
from bernardjkim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @zmb3 comment here #50366 (comment), consolidating the two pointer slice functions here, and will rebase #50366 and use it there as well.