Skip to content

Commit

Permalink
changes to default values for caption
Browse files Browse the repository at this point in the history
  • Loading branch information
greenwyrt committed Aug 21, 2023
1 parent 10900c6 commit c4d9717
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
8 changes: 6 additions & 2 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
# CHANGES

## Unreleased (Ver 2.3.0)
## Ver 2.3.0

Captioning interface and internals has been changed from 2.2.x versions with the help of @AshenColors.

- Changed: use `deque` for sending captions to achieve "rolling" effect
- Changed: use `deque` for sending captions to achieve "rolling" effect, and fixed repeating words

- Changed: default max line length 32 and max lines 3 for captioning

- Bug: Fixed flush captions sending extra empty line

- Bug: remove left whitespace from captions

Expand Down
4 changes: 2 additions & 2 deletions plover_cat/caption_dialog.ui
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<number>1</number>
</property>
<property name="value">
<number>42</number>
<number>32</number>
</property>
</widget>
</item>
Expand All @@ -62,7 +62,7 @@
<number>1</number>
</property>
<property name="value">
<number>2</number>
<number>3</number>
</property>
</widget>
</item>
Expand Down
2 changes: 1 addition & 1 deletion plover_cat/main_window.py
Original file line number Diff line number Diff line change
Expand Up @@ -3159,7 +3159,7 @@ def flush_caption(self):
if new_text == "":
self.cap_worker.intake("\n" + "\u2029")
else:
self.cap_worker.intake(new_text + "\u2029")
self.cap_worker.intake(new_text)
self.caption_cursor_pos = max(current_cursor.position(), current_cursor.anchor())

def modify_audiotime(self):
Expand Down

0 comments on commit c4d9717

Please sign in to comment.