Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for Java specific items #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

darinpope
Copy link

when doing protoc for Java, these were a few items that needed to be cleaned up:

proCore.proto:6:1: warning: Import action.proto is unused.
[libprotobuf WARNING google/protobuf/compiler/java/file.cc:235] dmxProfiles.proto: The file's outer class name, "DmxProfiles", matches the name of one of the types declared inside it when case is ignored. This can cause compilation issues on Windows / MacOS. Please either rename the type or use the java_outer_classname option to specify a different outer class name for the .proto file to be safe.
[libprotobuf WARNING google/protobuf/compiler/java/file.cc:235] keymapping.proto: The file's outer class name, "Keymapping", matches the name of one of the types declared inside it when case is ignored. This can cause compilation issues on Windows / MacOS. Please either rename the type or use the java_outer_classname option to specify a different outer class name for the .proto file to be safe.

when doing protoc for Java, these were a few items
that needed to be cleaned up
@greyshirtguy
Copy link
Owner

Sorry I've missed this for so long...
I'll need a bit of time to think how to best approach - as I have a bit of an automated process to generate the proto - and the next time I run it - it would loose your custom changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants