This repository has been archived by the owner on Aug 5, 2023. It is now read-only.
Added precision to 'write' request #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 96.51% 96.34% -0.18%
==========================================
Files 9 9
Lines 545 547 +2
==========================================
+ Hits 526 527 +1
- Misses 19 20 +1
Continue to review full report at Codecov.
|
ahesford
suggested changes
Jul 24, 2020
| loop: Optional[asyncio.AbstractEventLoop] = None, | ||
| redis_opts: Optional[dict] = None, | ||
| cache_expiry: int = 86400, | ||
| **kwargs |
| precision: Optional[str] = None, | ||
| rp: Optional[str] = None, | ||
| tag_columns: Optional[Iterable] = None, | ||
| **extra_tags, |
| raise NotImplementedError("'precision' parameter is not supported yet") | ||
| if precision and precision not in {"ns", "u", "ms", "s", "m", "h"}: | ||
| raise NotImplementedError("'precision' must must be one of " | ||
| "the following: 'ns', 'u', 'ms', 's', 'm', 'h'") |
There was a problem hiding this comment.
Should probably raise ValueError instead
| chunked: bool = False, | ||
| chunk_size: Optional[int] = None, | ||
| db: Optional[str] = None, | ||
| use_cache: bool = False, |
|
I would like to use this feature, too. Is there anything I could do help finalizing this PR ? |
|
i'd like to use this too, especially because is mentioned in the official optimization documentation: https://docs.influxdata.com/influxdb/cloud/write-data/best-practices/optimize-writes/#use-the-coarsest-time-precision-possible |
gusutabopb
force-pushed
the
master
branch
2 times, most recently
from
236e958 to
b124183
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the
precisionparameter, as InfluxDB API reference contains aprecisionparameter.The only thing is that I have not been able to setup the testing environment to check it works correctly. All the tests except
test_statement_errorpass.Hope it helps! Your library is very useful, thank you!
Tries to resolve #25