fix: Fix Release Automation Workflow #498
Open
+20
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
added
the
Bug
Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
requested review from
mattp-swirldslabs,
jjohannes and
rbarkerSL
and removed request for
rbarkerSL
|
@AlfredoG87 I took the liberty to push another commit to this branch. It replaces 'bumpVersion' with 'versionAsSpecified' that is already available (original motivated by how things are done in 'hedera-services'). 'versionAsSpecified' takes care of updating 'version.txt'. The Gradle configuration I added extends 'versionAsSpecified' to also update the 'Chart.yaml' files. See: |
jjohannes
previously approved these changes
Jan 15, 2025
This uses as much as possible of the functionality already provided through 'hiero-gradle-conventions' See: - https://github.com/hiero-ledger/hiero-gradle-conventions/tree/main?tab=readme-ov-file#publishing - https://github.com/hiero-ledger/hiero-gradle-conventions/blob/main/src/main/kotlin/org.hiero.gradle.feature.versioning.gradle.kts#L88-L102 Signed-off-by: Jendrik Johannes <[email protected]>
jjohannes
force-pushed
the
fix-release-automation
branch
from
810dbd6 to
f03d7cc
Compare
jjohannes
approved these changes
Jan 15, 2025
mishomihov00
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The release automation workflow was broken due to PR for Build migration to Hiero gradle plugins, this fixes it the issue with the version not been passed along correctly to the gradle
bumpVersiontaskRelated issue(s):
Fixes #496
Notes for reviewer:
Checklist