Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CODEOWNERS file #3384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mishomihov00
Copy link
Contributor

Description:

Fix CODEOWNERS file

Related issue(s):

Fixes #3381

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mishomihov00 mishomihov00 added this to the 0.65.0 milestone Jan 14, 2025
@mishomihov00 mishomihov00 self-assigned this Jan 14, 2025
@mishomihov00 mishomihov00 requested review from a team as code owners January 14, 2025 08:19
@mishomihov00 mishomihov00 linked an issue Jan 14, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 14, 2025

Test Results

 24 files  + 1  387 suites  +78   50m 32s ⏱️ - 7m 32s
615 tests  -  1  603 ✅ + 5  4 💤 ±0   8 ❌  - 6 
913 runs   - 90  899 ✅  - 81  4 💤  - 3  10 ❌  - 6 

For more details on these failures, see this check.

Results for commit 2f1abd7. ± Comparison against base commit e779b0f.

This pull request removes 4 and adds 3 tests. Note that renamed tests count towards both.
"after all" hook in "@web-socket-batch-1 eth_getBalance" ‑ RPC Server Acceptance Tests Acceptance tests @web-socket-batch-1 eth_getBalance "after all" hook in "@web-socket-batch-1 eth_getBalance"
"after all" hook in "RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests "after all" hook in "RPC Server Acceptance Tests"
"before all" hook in "Debug API Test Suite" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite "before all" hook in "Debug API Test Suite"
"before each" hook for "should execute "eth_getStorageAt" request to get current state changes" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get current state changes"
"after each" hook for "@release captures transfer events" ‑ RPC Server Acceptance Tests Acceptance tests @web-socket-batch-3 eth_subscribe "after each" hook for "@release captures transfer events"
"before all" hook for "Subscribes for debug" ‑ RPC Server Acceptance Tests Acceptance tests @web-socket-batch-3 eth_subscribe Subscribes to log events "before all" hook for "Subscribes for debug"
"before each" hook for "@release captures transfer events" ‑ RPC Server Acceptance Tests Acceptance tests @web-socket-batch-3 eth_subscribe "before each" hook for "@release captures transfer events"

♻️ This comment has been updated with latest results.

andrewb1269hg
andrewb1269hg previously approved these changes Jan 14, 2025
Signed-off-by: Mihail Mihov <[email protected]>
@mishomihov00 mishomihov00 force-pushed the 3381-chore-fix-codeowner-file-for-githubworkflow-folder branch from c5a2560 to 2f1abd7 Compare January 15, 2025 07:38
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (e779b0f) to head (2f1abd7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3384      +/-   ##
==========================================
- Coverage   84.89%   84.81%   -0.09%     
==========================================
  Files          65       69       +4     
  Lines        4562     4742     +180     
  Branches     1040     1067      +27     
==========================================
+ Hits         3873     4022     +149     
- Misses        338      401      +63     
+ Partials      351      319      -32     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 79.56% <ø> (ø)
server 83.28% <ø> (?)
ws-server 36.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: fix CODEOWNER file for .github/workflow folder
2 participants