Fix NodeUpdateTransaction always updating node zero (0.120) #10135
+47
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change node update to populate `createdTimestamp` if it's missing and an inner transaction. This is because nodes erroneously sent us updates instead of creates when migrating state. * Fix `NodeUpdateTransaction` updating the wrong node * Fix `NodeDeleteTransaction` deleting the wrong node Signed-off-by: Steven Sheehy <[email protected]>
xin-hedera
approved these changes
Jan 15, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.120 #10135 +/- ##
===================================================
+ Coverage 92.25% 93.23% +0.97%
+ Complexity 7821 817 -7004
===================================================
Files 953 335 -618
Lines 32749 11416 -21333
Branches 4151 1600 -2551
===================================================
- Hits 30214 10644 -19570
+ Misses 1559 654 -905
+ Partials 976 118 -858 ☔ View full report in Codecov by Sentry. |
edwin-greene
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry pick of #10134 to
release/0.120.createdTimestampif it's missing and an inner transaction. This is because nodes erroneously sent us updates instead of creates when migrating state.NodeUpdateTransactionupdating the wrong nodeNodeDeleteTransactiondeleting the wrong nodeRelated issue(s):
Fixes #10133
Notes for reviewer:
Checklist