Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing some docs #747

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

Neurone
Copy link
Contributor

@Neurone Neurone commented Dec 7, 2023

Description:

Fixing some docs, especially the need for --recursive parameter when cloning the repo.

Related issue(s):

Fixes later compilation errors if you don't include submodules in the repo.

   Compiling hedera-proto v0.8.1 (/home/developer/workspace/hedera/hedera-sdk-rust/protobufs)
error: failed to run custom build command for `hedera-proto v0.8.1 (/home/developer/workspace/hedera/hedera-sdk-rust/protobufs)`

Caused by:
  process didn't exit successfully: `/home/developer/workspace/hedera/hedera-sdk-rust/target/debug/build/hedera-proto-1822a64e67ed6dbd/build-script-build` (exit status: 1)
  --- stderr
  Error: No such file or directory (os error 2)
warning: build failed, waiting for other jobs to finish...

Notes for reviewer:
N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@RickyLB
Copy link
Contributor

RickyLB commented Dec 7, 2023

@Neurone Just need you to sign the commit please then let's get this merged!

Signed-off-by: Giuseppe Bertone <[email protected]>
@Neurone
Copy link
Contributor Author

Neurone commented Dec 8, 2023

Yep, sure. Done!

@RickyLB RickyLB merged commit 5d3a761 into hashgraph:main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants