Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable inline PCES #16450

Closed
wants to merge 4 commits into from
Closed

Conversation

lpetrovic05
Copy link
Member

closes #15907

Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 added this to the v0.57 milestone Nov 6, 2024
@lpetrovic05 lpetrovic05 self-assigned this Nov 6, 2024
Copy link

codacy-production bot commented Nov 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 44.44%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a838b95) 98006 64258 65.57%
Head commit (d98454d) 98022 (+16) 64264 (+6) 65.56% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16450) 18 8 44.44%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (a838b95) to head (d98454d).

Files with missing lines Patch % Lines
...lds/platform/builder/PlatformComponentBuilder.java 25.00% 10 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16450      +/-   ##
=============================================
- Coverage      63.89%   63.88%   -0.01%     
+ Complexity     20599    20598       -1     
=============================================
  Files           2541     2541              
  Lines          95241    95257      +16     
  Branches        9952     9953       +1     
=============================================
+ Hits           60852    60853       +1     
- Misses         30792    30802      +10     
- Partials        3597     3602       +5     
Files with missing lines Coverage Δ
...swirlds/platform/wiring/ComponentWiringConfig.java 100.00% <100.00%> (ø)
...va/com/swirlds/platform/wiring/PlatformWiring.java 80.88% <100.00%> (ø)
...lds/platform/builder/PlatformComponentBuilder.java 35.83% <25.00%> (-0.51%) ⬇️

... and 13 files with indirect coverage changes

Impacted file tree graph

@lpetrovic05 lpetrovic05 closed this Dec 6, 2024
@lpetrovic05 lpetrovic05 deleted the 15907-D-enable-inline-PCES branch December 18, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable inline PCES
1 participant