Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement ECDSA key support for yahcli accounts create #17293

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Refactor common key methods to new utility class

814de3f
Select commit
Loading
Failed to load commit list.
Open

feat: Implement ECDSA key support for yahcli accounts create #17293

Refactor common key methods to new utility class
814de3f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 1s

67.35% (+0.11%) compared to 70c450e

View this Pull Request on Codecov

67.35% (+0.11%) compared to 70c450e

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.35%. Comparing base (70c450e) to head (814de3f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
.../com/hedera/node/app/hapi/utils/keys/KeyUtils.java 85.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17293      +/-   ##
============================================
+ Coverage     67.24%   67.35%   +0.11%     
- Complexity    21991    22043      +52     
============================================
  Files          2583     2586       +3     
  Lines         96307    96384      +77     
  Branches      10054    10069      +15     
============================================
+ Hits          64763    64924     +161     
+ Misses        27839    27746      -93     
- Partials       3705     3714       +9     
Files with missing lines Coverage Δ
.../hedera/node/app/hapi/utils/keys/Ed25519Utils.java 100.00% <100.00%> (+6.45%) ⬆️
.../com/hedera/node/app/hapi/utils/keys/KeyUtils.java 85.00% <85.00%> (ø)

... and 30 files with indirect coverage changes

Impacted file tree graph