-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement metrics for block stream bucket uploader #17314
base: main
Are you sure you want to change the base?
feat: implement metrics for block stream bucket uploader #17314
Conversation
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17314 +/- ##
=========================================
Coverage 67.58% 67.59%
- Complexity 22142 22155 +13
=========================================
Files 2588 2589 +1
Lines 96701 96746 +45
Branches 10099 10100 +1
=========================================
+ Hits 65359 65399 +40
- Misses 27604 27608 +4
- Partials 3738 3739 +1
|
…ories Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Description:
Adding
BlockStreamBucketUploaderMetrics
class that will be used to update the following metrics:blocks.retained
(Gauge)blocks.uploaded
(Gauge)blocks.hashmismatch
(Gauge)uploads.failure
(Counter)uploads.success
(Counter)hash.mismatch
(Counter)upload.latency.latest
(Gauge)upload.latency.avg
(Accumulator)Related issue(s):
Fixes #16977
Checklist