Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement metrics for block stream bucket uploader #17314

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MiroslavGatsanoga
Copy link
Collaborator

@MiroslavGatsanoga MiroslavGatsanoga commented Jan 10, 2025

Description:

Adding BlockStreamBucketUploaderMetrics class that will be used to update the following metrics:

  • blocks.retained (Gauge)
  • blocks.uploaded (Gauge)
  • blocks.hashmismatch (Gauge)
  • uploads.failure (Counter)
  • uploads.success (Counter)
  • hash.mismatch (Counter)
  • upload.latency.latest (Gauge)
  • upload.latency.avg (Accumulator)

Related issue(s):

Fixes #16977

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.59 milestone Jan 10, 2025
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Jan 10, 2025
Copy link

codacy-production bot commented Jan 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 98.51%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f26286a) 96484 68945 71.46%
Head commit (3e607f4) 96529 (+45) 68986 (+41) 71.47% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17314) 67 66 98.51%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 97.01493% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.59%. Comparing base (f26286a) to head (3e607f4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...e/app/blocks/BlockStreamBucketUploaderMetrics.java 98.48% 0 Missing and 1 partial ⚠️
.../com/hedera/node/app/info/InfoInjectionModule.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17314   +/-   ##
=========================================
  Coverage     67.58%   67.59%           
- Complexity    22142    22155   +13     
=========================================
  Files          2588     2589    +1     
  Lines         96701    96746   +45     
  Branches      10099    10100    +1     
=========================================
+ Hits          65359    65399   +40     
- Misses        27604    27608    +4     
- Partials       3738     3739    +1     
Files with missing lines Coverage Δ
...e/app/blocks/BlockStreamBucketUploaderMetrics.java 98.48% <98.48%> (ø)
.../com/hedera/node/app/info/InfoInjectionModule.java 33.33% <0.00%> (-16.67%) ⬇️

... and 9 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Stream Bucket Uploader Metrics
1 participant