Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce generic custom fee limits #17315

Open
wants to merge 4 commits into
base: hip-991-topic-fees
Choose a base branch
from

Conversation

JivkoKelchev
Copy link
Contributor

@JivkoKelchev JivkoKelchev commented Jan 10, 2025

Description:
Adds the HIP changes from this PR

Related issue(s):

Fixes #17348

Notes for reviewer:

Other than protobuf changes, there is a precheck validation in TransactionChecker that will fail any transaction, that doesn't support custom fee limits, but the users are providing such.

Signed-off-by: Zhivko Kelchev <[email protected]>
@JivkoKelchev JivkoKelchev changed the base branch from main to hip-991-topic-fees January 10, 2025 13:23
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 63.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (be1981d) 96191 68558 71.27%
Head commit (aa773a6) 96306 (+115) 68608 (+50) 71.24% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17315) 150 95 63.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codacy-production bot commented Jan 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% (target: -1.00%) 53.85%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (88ec619) 96540 68989 71.46%
Head commit (d64317c) 96552 (+12) 69055 (+66) 71.52% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17315) 13 7 53.85%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (88ec619) to head (d64317c).

Files with missing lines Patch % Lines
.../hedera/node/app/workflows/TransactionChecker.java 38.46% 6 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##             hip-991-topic-fees   #17315      +/-   ##
========================================================
+ Coverage                 67.57%   67.64%   +0.06%     
- Complexity                22159    22184      +25     
========================================================
  Files                      2589     2589              
  Lines                     96757    96769      +12     
  Branches                  10126    10130       +4     
========================================================
+ Hits                      65385    65455      +70     
+ Misses                    27616    27562      -54     
+ Partials                   3756     3752       -4     
Files with missing lines Coverage Δ
.../impl/validators/ConsensusCustomFeesValidator.java 56.25% <ø> (ø)
.../hedera/node/app/workflows/TransactionChecker.java 87.89% <38.46%> (-4.52%) ⬇️

... and 21 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Zhivko Kelchev <[email protected]>
@JivkoKelchev JivkoKelchev changed the title Hip 991 protobuf changes feat: Introduce generic custom fee limits Jan 13, 2025
@JivkoKelchev JivkoKelchev self-assigned this Jan 13, 2025
@JivkoKelchev JivkoKelchev added this to the v0.59 milestone Jan 13, 2025
@JivkoKelchev JivkoKelchev marked this pull request as ready for review January 13, 2025 15:16
@JivkoKelchev JivkoKelchev requested review from a team as code owners January 13, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants