-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce generic custom fee limits #17315
base: hip-991-topic-fees
Are you sure you want to change the base?
Conversation
Signed-off-by: Zhivko Kelchev <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hip-991-topic-fees #17315 +/- ##
========================================================
+ Coverage 67.57% 67.64% +0.06%
- Complexity 22159 22184 +25
========================================================
Files 2589 2589
Lines 96757 96769 +12
Branches 10126 10130 +4
========================================================
+ Hits 65385 65455 +70
+ Misses 27616 27562 -54
+ Partials 3756 3752 -4
|
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
Description:
Adds the HIP changes from this PR
Related issue(s):
Fixes #17348
Notes for reviewer:
Other than protobuf changes, there is a precheck validation in TransactionChecker that will fail any transaction, that doesn't support custom fee limits, but the users are providing such.