-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: implement semantic release for release workflow #17332
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
…ph/hedera-services into semantic-release-workflow-update
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
cadf0ac
to
8e6181d
Compare
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17332 +/- ##
============================================
+ Coverage 67.30% 67.58% +0.28%
- Complexity 21996 22135 +139
============================================
Files 2582 2588 +6
Lines 96248 96667 +419
Branches 10055 10099 +44
============================================
+ Hits 64775 65335 +560
+ Misses 27779 27589 -190
- Partials 3694 3743 +49 |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
|
||
permissions: | ||
id-token: write | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this permission may have to be changed to write as per this document
Description:
This PR accomplishes 3 things:
zxf-trigger-semantic-release.yaml
which will call the semantic release utility to tag a branch at a specificbuild_xxxxx
. This will apply a version tag to thebuild_xxxxx
commit, then kick off the release process.zxf-version-roll.yaml
to roll theversion.txt
file forward one minor version.This PR is how we plan on releasing
v0.59.0
.Related issue(s):
Fixes #14967
Notes for reviewer:
There are a couple of changes that need to happen before this PR is merged:
zxf-trigger-semantic-release.yaml
Run Semantic Release
step, add innpx semantic-release
zxf-version-roll.yaml
Checkout Code
step, changeref
from14967-semantic-release-workflow-update
tomain
Publish to Maven Central
step, remove thePpublishTestRelease=true
flagGeneral:
v0.58.0
tag on the mainline before merging this PR, so we can trigger semantic release and have it start atv0.59.0
rather thanv0.1.0
Checklist
Documented (Code comments, README, etc.)
The primary documentation for the CITR release process is captured here: docs: Updated documentation to incorporate CITR & Semantic Release #17327
Tested (unit, integration, etc.)
This has been tested on a private branch several times to confirm it works. The
npx semantic-release
has not yet been tested on a private branch as I did not want to accidentally cut a release.