Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: implement semantic release for release workflow #17332

Open
wants to merge 58 commits into
base: main
Choose a base branch
from

Conversation

andrewb1269hg
Copy link
Contributor

@andrewb1269hg andrewb1269hg commented Jan 11, 2025

Description:

This PR accomplishes 3 things:

  1. Implement semantic release for versioning off the mainline.
  2. Implement a workflow zxf-trigger-semantic-release.yaml which will call the semantic release utility to tag a branch at a specific build_xxxxx. This will apply a version tag to the build_xxxxx commit, then kick off the release process.
  3. Implement a workflow zxf-version-roll.yaml to roll the version.txt file forward one minor version.

This PR is how we plan on releasing v0.59.0.

Related issue(s):

Fixes #14967

Notes for reviewer:

There are a couple of changes that need to happen before this PR is merged:

zxf-trigger-semantic-release.yaml

  • Change default input value from "43" to ""
  • Inside Run Semantic Release step, add in npx semantic-release

zxf-version-roll.yaml

  • Inside Checkout Code step, change ref from 14967-semantic-release-workflow-update to main
  • Inside Publish to Maven Central step, remove the PpublishTestRelease=true flag

General:

  • Apply a v0.58.0 tag on the mainline before merging this PR, so we can trigger semantic release and have it start at v0.59.0 rather than v0.1.0

Checklist

  • Documented (Code comments, README, etc.)

  • The primary documentation for the CITR release process is captured here: docs: Updated documentation to incorporate CITR & Semantic Release #17327

  • Tested (unit, integration, etc.)

  • This has been tested on a private branch several times to confirm it works. The npx semantic-release has not yet been tested on a private branch as I did not want to accidentally cut a release.

san-est and others added 30 commits November 15, 2024 16:39
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
…ph/hedera-services into semantic-release-workflow-update
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
@andrewb1269hg andrewb1269hg force-pushed the 14967-semantic-release-workflow-update branch from cadf0ac to 8e6181d Compare January 12, 2025 00:52
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (7229541) to head (96f55ef).
Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17332      +/-   ##
============================================
+ Coverage     67.30%   67.58%   +0.28%     
- Complexity    21996    22135     +139     
============================================
  Files          2582     2588       +6     
  Lines         96248    96667     +419     
  Branches      10055    10099      +44     
============================================
+ Hits          64775    65335     +560     
+ Misses        27779    27589     -190     
- Partials       3694     3743      +49     

see 98 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 12, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.29% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7229541) 96031 68318 71.14%
Head commit (96f55ef) 96286 (+255) 68783 (+465) 71.44% (+0.29%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17332) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@andrewb1269hg andrewb1269hg self-assigned this Jan 12, 2025
@andrewb1269hg andrewb1269hg added this to the v0.59 milestone Jan 12, 2025
@andrewb1269hg andrewb1269hg changed the title 14967 semantic release workflow update ci: implement semantic release for release workflow Jan 12, 2025
@andrewb1269hg andrewb1269hg marked this pull request as ready for review January 13, 2025 19:24
@andrewb1269hg andrewb1269hg requested review from a team as code owners January 13, 2025 19:24
Signed-off-by: Andrew Brandt <[email protected]>

permissions:
id-token: write
contents: read
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this permission may have to be changed to write as per this document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: enable semantic release in gh release workflows
3 participants