Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HIP-551 atomic batch transactions #17333

Draft
wants to merge 16 commits into
base: 17360-avoid-circular-dependency
Choose a base branch
from

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Jan 12, 2025

Description:
Feature branch for HIP-551 Atomic Batch Transactions

Related issue(s):
Fixes #17318
Fixes #17319
Fixes #17320

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Kim Rader <[email protected]>
@kimbor kimbor added this to the v0.59 milestone Jan 12, 2025
@kimbor kimbor self-assigned this Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (17360-avoid-circular-dependency@b3a8f69). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../src/main/java/com/hedera/hapi/util/HapiUtils.java 30.00% 7 Missing ⚠️
.../hedera/node/app/workflows/TransactionChecker.java 0.00% 0 Missing and 1 partial ⚠️
...pp/workflows/dispatcher/TransactionDispatcher.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##             17360-avoid-circular-dependency   #17333   +/-   ##
==================================================================
  Coverage                                   ?   67.72%           
  Complexity                                 ?    22204           
==================================================================
  Files                                      ?     2596           
  Lines                                      ?    96689           
  Branches                                   ?    10082           
==================================================================
  Hits                                       ?    65486           
  Misses                                     ?    27459           
  Partials                                   ?     3744           
Files with missing lines Coverage Δ
...m/hedera/hapi/util/UnknownHederaFunctionality.java 100.00% <ø> (ø)
...edera/node/app/hapi/utils/CommonPbjConverters.java 68.44% <ø> (ø)
...e/addressbook/impl/handlers/NodeCreateHandler.java 98.03% <ø> (ø)
...e/addressbook/impl/handlers/NodeDeleteHandler.java 96.96% <ø> (ø)
...e/addressbook/impl/handlers/NodeUpdateHandler.java 95.94% <ø> (ø)
.../main/java/com/hedera/node/app/spi/AppContext.java 33.33% <ø> (ø)
.../hedera/node/app/spi/authorization/Authorizer.java 100.00% <ø> (ø)
...hedera/node/app/spi/workflows/DispatchOptions.java 100.00% <ø> (ø)
...m/hedera/node/app/spi/workflows/HandleContext.java 75.00% <ø> (ø)
...edera/node/app/spi/workflows/PreHandleContext.java 0.00% <ø> (ø)
... and 169 more

Impacted file tree graph

Copy link

codacy-production bot commented Jan 12, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.07% (target: -1.00%) 41.94%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7c836a9) 96454 69129 71.67%
Head commit (818cdbc) 96472 (+18) 69078 (-51) 71.60% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17333) 31 13 41.94%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Lev Povolotsky <[email protected]>
@kimbor kimbor changed the base branch from main to 17360-avoid-circular-dependency January 13, 2025 21:53
@kimbor kimbor changed the base branch from 17360-avoid-circular-dependency to main January 14, 2025 23:31
@kimbor kimbor changed the base branch from main to 17360-avoid-circular-dependency January 14, 2025 23:32
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants