Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add V059HintsSchema and HintsService stores #17335

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

tinker-michaelj and others added 23 commits January 3, 2025 21:47
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
…ry/HistoryLibrary.java

Co-authored-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
…ry/HistoryLibrary.java

Co-authored-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
@tinker-michaelj tinker-michaelj marked this pull request as draft January 13, 2025 04:51
@tinker-michaelj tinker-michaelj added this to the v0.59 milestone Jan 13, 2025
@tinker-michaelj tinker-michaelj self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (8621074) to head (d048a26).

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##             17220-tss-block-hash-signer   #17335      +/-   ##
=================================================================
+ Coverage                          67.43%   67.45%   +0.01%     
- Complexity                         22166    22183      +17     
=================================================================
  Files                               2598     2600       +2     
  Lines                              96792    96856      +64     
  Branches                           10105    10109       +4     
=================================================================
+ Hits                               65275    65335      +60     
  Misses                             27794    27794              
- Partials                            3723     3727       +4     
Files with missing lines Coverage Δ
...a/com/hedera/node/app/hints/impl/HintsContext.java 100.00% <100.00%> (ø)
...hedera/node/app/hints/schemas/V059HintsSchema.java 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8621074) 96575 68846 71.29%
Head commit (d048a26) 96639 (+64) 68910 (+64) 71.31% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17335) 64 64 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tinker-michaelj tinker-michaelj changed the title chore: add V059HintsSchema and SigningContext chore: add V059HintsSchema and HintsService stores Jan 13, 2025
Signed-off-by: Michael Tinker <[email protected]>
Base automatically changed from 17220-tss-block-hash-signer to main January 15, 2025 01:17
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant