-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Combine transaction.proto and transaction_body.proto into a single file #17361
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kim Rader <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17361 +/- ##
============================================
+ Coverage 67.73% 67.79% +0.06%
- Complexity 22199 22221 +22
============================================
Files 2594 2594
Lines 96671 96671
Branches 10081 10081
============================================
+ Hits 65477 65539 +62
+ Misses 27448 27390 -58
+ Partials 3746 3742 -4
|
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
body
from transaction.protoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for hedera-smart-contract-service-impl
* various parameters required to process a transaction. | ||
*/ | ||
message TransactionBody { | ||
reserved 30, 61, 62, 63, 64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can avoid changing all imports by adding this comment with pbj option.
reserved 30, 61, 62, 63, 64; | |
// <<<pbj.java_package = "com.hedera.hapi.node.transaction">>> | |
reserved 30, 61, 62, 63, 64; |
Description:
Implement option 2 from issue #17360
Related issue(s):
Fixes #17360