Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wiring framework module #17385

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore: wiring framework module #17385

wants to merge 6 commits into from

Conversation

mxtartaglia-sl
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mxtartaglia-sl mxtartaglia-sl self-assigned this Jan 15, 2025
@mxtartaglia-sl mxtartaglia-sl added this to the v0.59 milestone Jan 15, 2025
@mxtartaglia-sl mxtartaglia-sl changed the title wiring_framework chore: wiring framework module Jan 15, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (46446f1) 96454 69071 71.61%
Head commit (298e0fb) 96502 (+48) 69186 (+115) 71.69% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17385) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.86%. Comparing base (46446f1) to head (298e0fb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17385      +/-   ##
============================================
+ Coverage     67.73%   67.86%   +0.13%     
- Complexity    22199    22332     +133     
============================================
  Files          2594     2606      +12     
  Lines         96671    96872     +201     
  Branches      10081    10094      +13     
============================================
+ Hits          65477    65740     +263     
+ Misses        27448    27398      -50     
+ Partials       3746     3734      -12     
Files with missing lines Coverage Δ
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 94.01% <ø> (ø)
...wirlds/merkledb/files/hashmap/HalfDiskHashMap.java 76.35% <ø> (ø)
.../com/swirlds/platform/builder/PlatformBuilder.java 0.00% <ø> (ø)
...irlds/platform/builder/PlatformBuildingBlocks.java 0.00% <ø> (ø)
...lds/platform/builder/PlatformComponentBuilder.java 36.03% <ø> (ø)
.../java/com/swirlds/platform/cli/DiagramCommand.java 0.00% <ø> (ø)
...com/swirlds/platform/cli/DiagramLegendCommand.java 0.00% <ø> (ø)
...platform/components/consensus/ConsensusEngine.java 0.00% <ø> (ø)
...latform/config/PlatformConfigurationExtension.java 100.00% <ø> (ø)
...rlds/platform/event/preconsensus/PcesReplayer.java 69.44% <ø> (ø)
... and 90 more

... and 28 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant