Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stabilize DeterministicThrottleTest.throttlesWithinPermissibleTolerance() #17412

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MiroslavGatsanoga
Copy link
Collaborator

Description:

Related issue(s):

Fixes #13667

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <[email protected]>
@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.59 milestone Jan 16, 2025
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Jan 16, 2025
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Copy link

codacy-production bot commented Jan 16, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.71% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9142a70) 96670 69527 71.92%
Head commit (ca03f38) 96710 (+40) 70241 (+714) 72.63% (+0.71%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17412) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (9142a70) to head (ca03f38).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17412      +/-   ##
============================================
+ Coverage     68.04%   68.69%   +0.65%     
- Complexity    22387    22520     +133     
============================================
  Files          2605     2605              
  Lines         96887    96927      +40     
  Branches      10098    10101       +3     
============================================
+ Hits          65927    66586     +659     
+ Misses        27208    26535     -673     
- Partials       3752     3806      +54     

see 28 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Miroslav Gatsanoga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize DeterministicThrottleTest.throttlesWithinPermissibleTolerance()
1 participant