Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate non-standard hedera.shard/hedera.realm configurations #17460

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

vtronkov
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

JivkoKelchev and others added 5 commits January 21, 2025 13:09
Copy link

codacy-production bot commented Jan 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.24% (target: -1.00%) 89.62%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3e8fa1f) 97675 71128 72.82%
Head commit (1083df2) 98113 (+438) 71210 (+82) 72.58% (-0.24%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17460) 212 190 89.62%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 87.73585% with 26 lines in your changes missing coverage. Please review.

Project coverage is 68.64%. Comparing base (3e8fa1f) to head (1083df2).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ntract/impl/exec/scope/HandleHederaOperations.java 74.07% 14 Missing ⚠️
...p/service/contract/impl/utils/ConversionUtils.java 82.14% 5 Missing ⚠️
.../impl/handlers/CryptoGetAccountBalanceHandler.java 0.00% 1 Missing and 3 partials ⚠️
...systemcontracts/hts/create/ClassicCreatesCall.java 0.00% 2 Missing ⚠️
...ice/token/impl/handlers/FinalizeRecordHandler.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17460      +/-   ##
============================================
- Coverage     68.91%   68.64%   -0.28%     
+ Complexity    22667    22626      -41     
============================================
  Files          2613     2619       +6     
  Lines         97892    98417     +525     
  Branches      10156    10184      +28     
============================================
+ Hits          67463    67559      +96     
- Misses        26613    26998     +385     
- Partials       3816     3860      +44     
Files with missing lines Coverage Δ
...ddressbook/impl/schemas/V053AddressBookSchema.java 81.81% <100.00%> (-12.58%) ⬇️
...in/impl/handlers/ReadableFreezeUpgradeActions.java 85.71% <100.00%> (-1.27%) ⬇️
...chedule/impl/handlers/AbstractScheduleHandler.java 85.27% <100.00%> (-1.35%) ⬇️
...impl/exec/scope/DefaultVerificationStrategies.java 81.81% <100.00%> (+10.38%) ⬆️
.../impl/exec/scope/HandleHederaNativeOperations.java 93.18% <100.00%> (+0.68%) ⬆️
...ntract/impl/exec/scope/HederaNativeOperations.java 100.00% <100.00%> (ø)
.../impl/exec/systemcontracts/hss/HssCallAttempt.java 81.25% <100.00%> (+3.20%) ⬆️
...act/impl/exec/systemcontracts/hts/ReturnTypes.java 92.30% <100.00%> (-7.70%) ⬇️
...ct/impl/exec/systemcontracts/hts/SyntheticIds.java 95.45% <100.00%> (+9.09%) ⬆️
...cts/hts/isapprovedforall/IsApprovedForAllCall.java 97.29% <100.00%> (+0.32%) ⬆️
... and 24 more

... and 100 files with indirect coverage changes

Impacted file tree graph

@vtronkov vtronkov changed the title Non zero shard realm feat: Validate non-standard hedera.shard/hedera.realm configurations Jan 22, 2025
@vtronkov vtronkov added this to the v0.60 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants