-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add synthetic node creates to record stream at genesis #17461
base: main
Are you sure you want to change the base?
feat: add synthetic node creates to record stream at genesis #17461
Conversation
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17461 +/- ##
=========================================
Coverage 68.99% 68.99%
- Complexity 22770 22779 +9
=========================================
Files 2619 2620 +1
Lines 98268 98311 +43
Branches 10184 10187 +3
=========================================
+ Hits 67796 67831 +35
- Misses 26644 26651 +7
- Partials 3828 3829 +1
|
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Description:
Created new
SyntheticNodeCreator
class used for getting the nodes for which we need to create synthetic transactions for and addedSystemSetup.createNodeRecordBuilders()
method to add those node create transactions to the record stream.Related issue(s):
Fixes #17015
Notes for reviewer:
Checklist