Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add synthetic node creates to record stream at genesis #17461

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MiroslavGatsanoga
Copy link
Collaborator

@MiroslavGatsanoga MiroslavGatsanoga commented Jan 21, 2025

Description:

Created new SyntheticNodeCreator class used for getting the nodes for which we need to create synthetic transactions for and added SystemSetup.createNodeRecordBuilders() method to add those node create transactions to the record stream.

Related issue(s):

Fixes #17015

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.59 milestone Jan 21, 2025
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Jan 21, 2025
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Copy link

codacy-production bot commented Jan 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fadab3b) 98051 71473 72.89%
Head commit (a1182a9) 98094 (+43) 71509 (+36) 72.90% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17461) 44 44 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.99%. Comparing base (fadab3b) to head (a1182a9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...etworkadmin/impl/schemas/SyntheticNodeCreator.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17461   +/-   ##
=========================================
  Coverage     68.99%   68.99%           
- Complexity    22770    22779    +9     
=========================================
  Files          2619     2620    +1     
  Lines         98268    98311   +43     
  Branches      10184    10187    +3     
=========================================
+ Hits          67796    67831   +35     
- Misses        26644    26651    +7     
- Partials       3828     3829    +1     
Files with missing lines Coverage Δ
.../node/app/workflows/handle/record/SystemSetup.java 93.60% <100.00%> (+0.71%) ⬆️
...etworkadmin/impl/schemas/SyntheticNodeCreator.java 92.30% <92.30%> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

@MiroslavGatsanoga MiroslavGatsanoga marked this pull request as ready for review January 22, 2025 17:31
@MiroslavGatsanoga MiroslavGatsanoga requested review from a team as code owners January 22, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record-centric mirror nodes need synthetic NodeCreates at genesis
1 participant