Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session breaks with multiple tabs open #387

Open
sentx-io opened this issue Dec 22, 2024 · 3 comments · Fixed by hgraph-io/hedera-wallet-connect#15 · May be fixed by #412
Open

Session breaks with multiple tabs open #387

sentx-io opened this issue Dec 22, 2024 · 3 comments · Fixed by hgraph-io/hedera-wallet-connect#15 · May be fixed by #412

Comments

@sentx-io
Copy link

Wallet Connect will fail to return a transaction result to the source window as soon as a new tab is opened. It will actually return it to the wrong one instead, and the window that initially sent the transaction to be executed will never receive the acknowledgement from the wallet.

To reproduce:

Connect to a Dapp using Wallet Connect
Open a new tab in the same url
Execute a transaction on tab A and simply hit reject on the wallet
Execute a transaction on tab B and reject
One of the tabs will never get the ping back from the wallet. Instead, all of them will go to the same source window, whether or not it was the one that sent the transaction to be executed.

This is a big limitation and makes Wallet Connect very unreliable on any DApp where users often have multiple windows or tabs open (stats, analytics, feeds, market trades).

Any native connectors before Wallet Connect (hashconnect) work fine and do not have this issue.

@AdrianKBL
Copy link

We completely agree with @sentx-io . This issue has been reported multiple times by Kabila, including directly to the WalletConnect team. Unfortunately, the response has consistently been:

This is a known limitation since v2 was launched. Only the latest connection, i.e., the most recently opened tab, receives messages from the relay.

This limitation is causing significant challenges within our Dapps. The behavior severely impacts usability, especially when users rely on multiple tabs or devices for seamless interactions.

To be honest, we’re uncertain about the best path forward to address this limitation, but it’s a critical issue that warrants further discussion and potential resolution.

image
image

@tmctl
Copy link
Contributor

tmctl commented Jan 14, 2025

interesting that a merge into a fork closes the issue, re-opening

@tmctl tmctl reopened this Jan 14, 2025
@tmctl tmctl linked a pull request Jan 14, 2025 that will close this issue
2 tasks
@tmctl
Copy link
Contributor

tmctl commented Jan 14, 2025

@AdrianKBL @sentx-io

Can you provide feedback on this pr? #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment